Refactor schema representation and code generation #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tomhoule
force-pushed
the
schema-graph
branch
5 times, most recently
from
10236d8 to
f2b3eee
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tomhoule
force-pushed
the
schema-graph
branch
from
15362fa to
986e75f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tomhoule
force-pushed
the
schema-graph
branch
7 times, most recently
from
618f2ce to
ecd34f2
Compare
Squashed: - Flatten type-refining fragments ...when they are the only selection on the variant.
|
I'm going to merge this soon, since it my view it's a clear improvement, and it's blocking me from working on other issues. |
|
Sounds good to me; I won't block it, but I also haven't gone through with a fine-tooth comb either. The broad strokes I see when skimming look good though. |
|
Yes it's way too big to expect a thorough review - I wish I'd managed to break it into reviewable parts, but it started as an experiment and was that for a long time, and by the time I found a structure that worked very nicely there were a bunch of improvements and refactorings mixed together. And I don't have the spare time to make it much tidier unfortunately. Thanks for taking a look though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge refactoring based on an idea to model the schema with a proper normalized representation. The results so far are promising in terms of code clarity and maintainability. At the moment, this is far from complete.
Previously, name resolution, query validation and code generation all happened in one pass. In this PR, these three are cleanly separated, leading to much more understandable code in my opinion.